From 8c36e5fa0115e7101b1c340d6a8be0fc888e01d6 Mon Sep 17 00:00:00 2001 From: Dragory <2606411+Dragory@users.noreply.github.com> Date: Sun, 12 Jan 2020 11:43:56 +0200 Subject: [PATCH] logs: make sure the passed member object is stripped --- backend/src/plugins/Logs.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/backend/src/plugins/Logs.ts b/backend/src/plugins/Logs.ts index 921d87e3..a3f7cf75 100644 --- a/backend/src/plugins/Logs.ts +++ b/backend/src/plugins/Logs.ts @@ -356,9 +356,11 @@ export class LogsPlugin extends ZeppelinPlugin { async onMemberUpdate(_, member: Member, oldMember: Member) { if (!oldMember) return; + const logMember = stripObjectToScalars(member, ["user", "roles"]); + if (member.nick !== oldMember.nick) { this.guildLogs.log(LogType.MEMBER_NICK_CHANGE, { - member, + member: logMember, oldNick: oldMember.nick != null ? oldMember.nick : "", newNick: member.nick != null ? member.nick : "", }); @@ -379,7 +381,7 @@ export class LogsPlugin extends ZeppelinPlugin { this.guildLogs.log( LogType.MEMBER_ROLE_CHANGES, { - member, + member: logMember, addedRoles: addedRoles .map(roleId => this.guild.roles.get(roleId) || { id: roleId, name: `Unknown (${roleId})` }) .map(r => r.name) @@ -397,7 +399,7 @@ export class LogsPlugin extends ZeppelinPlugin { this.guildLogs.log( LogType.MEMBER_ROLE_ADD, { - member, + member: logMember, roles: addedRoles .map(roleId => this.guild.roles.get(roleId) || { id: roleId, name: `Unknown (${roleId})` }) .map(r => r.name) @@ -411,7 +413,7 @@ export class LogsPlugin extends ZeppelinPlugin { this.guildLogs.log( LogType.MEMBER_ROLE_REMOVE, { - member, + member: logMember, roles: removedRoles .map(roleId => this.guild.roles.get(roleId) || { id: roleId, name: `Unknown (${roleId})` }) .map(r => r.name)