Update djs & knub (#395)

* update pkgs

Signed-off-by: GitHub <noreply@github.com>

* new knub typings

Signed-off-by: GitHub <noreply@github.com>

* more pkg updates

Signed-off-by: GitHub <noreply@github.com>

* more fixes

Signed-off-by: GitHub <noreply@github.com>

* channel typings

Signed-off-by: GitHub <noreply@github.com>

* more message utils typings fixes

Signed-off-by: GitHub <noreply@github.com>

* migrate permissions

Signed-off-by: GitHub <noreply@github.com>

* fix: InternalPoster webhookables

Signed-off-by: GitHub <noreply@github.com>

* djs typings: Attachment & Util

Signed-off-by: GitHub <noreply@github.com>

* more typings

Signed-off-by: GitHub <noreply@github.com>

* fix: rename permissionNames

Signed-off-by: GitHub <noreply@github.com>

* more fixes

Signed-off-by: GitHub <noreply@github.com>

* half the number of errors

* knub commands => messageCommands

Signed-off-by: GitHub <noreply@github.com>

* configPreprocessor => configParser

Signed-off-by: GitHub <noreply@github.com>

* fix channel.messages

Signed-off-by: GitHub <noreply@github.com>

* revert automod any typing

Signed-off-by: GitHub <noreply@github.com>

* more configParser typings

Signed-off-by: GitHub <noreply@github.com>

* revert

Signed-off-by: GitHub <noreply@github.com>

* remove knub type params

Signed-off-by: GitHub <noreply@github.com>

* fix more MessageEmbed / MessageOptions

Signed-off-by: GitHub <noreply@github.com>

* dumb commit for @almeidx to see why this is stupid

Signed-off-by: GitHub <noreply@github.com>

* temp disable custom_events

Signed-off-by: GitHub <noreply@github.com>

* more minor typings fixes - 23 err left

Signed-off-by: GitHub <noreply@github.com>

* update djs dep

* +debug build method (revert this)

Signed-off-by: GitHub <noreply@github.com>

* Revert "+debug build method (revert this)"

This reverts commit a80af1e729.

* Redo +debug build (Revert this)

Signed-off-by: GitHub <noreply@github.com>

* uniform before/after Load shorthands

Signed-off-by: GitHub <noreply@github.com>

* remove unused imports & add prettier plugin

Signed-off-by: GitHub <noreply@github.com>

* env fixes for web platform hosting

Signed-off-by: GitHub <noreply@github.com>

* feat: knub v32-next; related fixes

* fix: allow legacy keys in change_perms action

* fix: request Message Content intent

* fix: use Knub's config validation logic in API

* fix(dashboard): fix error when there are no message and/or slash commands in a plugin

* fix(automod): start_thread action thread options

* fix(CustomEvents): message command types

* chore: remove unneeded type annotation

* feat: add forum channel icon; use thread icon for news threads

* chore: make tslint happy

* chore: fix formatting

---------

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: almeidx <almeidx@pm.me>
Co-authored-by: Dragory <2606411+Dragory@users.noreply.github.com>

backend/src/plugins/Mutes/MutesPlugin.ts

@@ -2,9 +2,10 @@ import { GuildMember, Snowflake } from "discord.js";
 import { EventEmitter } from "events";
 import { GuildArchives } from "../../data/GuildArchives";
 import { GuildCases } from "../../data/GuildCases";
+import { onGuildEvent } from "../../data/GuildEvents";
 import { GuildLogs } from "../../data/GuildLogs";
 import { GuildMutes } from "../../data/GuildMutes";
-import { mapToPublicFn } from "../../pluginUtils";
+import { makeIoTsConfigParser, mapToPublicFn } from "../../pluginUtils";
 import { CasesPlugin } from "../Cases/CasesPlugin";
 import { LogsPlugin } from "../Logs/LogsPlugin";
 import { zeppelinGuildPlugin } from "../ZeppelinPluginBlueprint";
@@ -13,15 +14,13 @@ import { ClearMutesCmd } from "./commands/ClearMutesCmd";
 import { ClearMutesWithoutRoleCmd } from "./commands/ClearMutesWithoutRoleCmd";
 import { MutesCmd } from "./commands/MutesCmd";
 import { ClearActiveMuteOnMemberBanEvt } from "./events/ClearActiveMuteOnMemberBanEvt";
-import { ClearActiveMuteOnRoleRemovalEvt } from "./events/ClearActiveMuteOnRoleRemovalEvt";
 import { ReapplyActiveMuteOnJoinEvt } from "./events/ReapplyActiveMuteOnJoinEvt";
+import { clearMute } from "./functions/clearMute";
 import { muteUser } from "./functions/muteUser";
 import { offMutesEvent } from "./functions/offMutesEvent";
 import { onMutesEvent } from "./functions/onMutesEvent";
 import { unmuteUser } from "./functions/unmuteUser";
 import { ConfigSchema, MutesPluginType } from "./types";
-import { onGuildEvent } from "../../data/GuildEvents";
-import { clearMute } from "./functions/clearMute";
 
 const defaultOptions = {
   config: {
@@ -66,14 +65,15 @@ export const MutesPlugin = zeppelinGuildPlugin<MutesPluginType>()({
   showInDocs: true,
   info: {
     prettyName: "Mutes",
+    configSchema: ConfigSchema,
   },
 
-  configSchema: ConfigSchema,
   dependencies: () => [CasesPlugin, LogsPlugin],
+  configParser: makeIoTsConfigParser(ConfigSchema),
   defaultOptions,
 
   // prettier-ignore
-  commands: [
+  messageCommands: [
     MutesCmd,
     ClearBannedMutesCmd,
     ClearMutesWithoutRoleCmd,
@@ -105,22 +105,26 @@ export const MutesPlugin = zeppelinGuildPlugin<MutesPluginType>()({
   },
 
   beforeLoad(pluginData) {
-    pluginData.state.mutes = GuildMutes.getGuildInstance(pluginData.guild.id);
-    pluginData.state.cases = GuildCases.getGuildInstance(pluginData.guild.id);
-    pluginData.state.serverLogs = new GuildLogs(pluginData.guild.id);
-    pluginData.state.archives = GuildArchives.getGuildInstance(pluginData.guild.id);
+    const { state, guild } = pluginData;
 
-    pluginData.state.events = new EventEmitter();
+    state.mutes = GuildMutes.getGuildInstance(guild.id);
+    state.cases = GuildCases.getGuildInstance(guild.id);
+    state.serverLogs = new GuildLogs(guild.id);
+    state.archives = GuildArchives.getGuildInstance(guild.id);
+
+    state.events = new EventEmitter();
   },
 
   afterLoad(pluginData) {
-    pluginData.state.unregisterGuildEventListener = onGuildEvent(pluginData.guild.id, "expiredMute", (mute) =>
-      clearMute(pluginData, mute),
-    );
+    const { state, guild } = pluginData;
+
+    state.unregisterGuildEventListener = onGuildEvent(guild.id, "expiredMute", (mute) => clearMute(pluginData, mute));
   },
 
   beforeUnload(pluginData) {
-    pluginData.state.unregisterGuildEventListener?.();
-    pluginData.state.events.removeAllListeners();
+    const { state, guild } = pluginData;
+
+    state.unregisterGuildEventListener?.();
+    state.events.removeAllListeners();
   },
 });

backend/src/plugins/Mutes/commands/ClearBannedMutesCmd.ts

@@ -1,4 +1,4 @@
-import { Snowflake, User } from "discord.js";
+import { Snowflake } from "discord.js";
 import { sendSuccessMessage } from "../../../pluginUtils";
 import { mutesCmd } from "../types";
 

backend/src/plugins/Mutes/commands/MutesCmd.ts

@@ -1,4 +1,11 @@
-import { GuildMember, MessageActionRow, MessageButton, MessageComponentInteraction, Snowflake } from "discord.js";
+import {
+  ActionRowBuilder,
+  ButtonBuilder,
+  ButtonStyle,
+  GuildMember,
+  MessageComponentInteraction,
+  Snowflake,
+} from "discord.js";
 import moment from "moment-timezone";
 import { commandTypeHelpers as ct } from "../../../commandTypes";
 import { humanizeDurationShort } from "../../../humanizeDurationShort";
@@ -192,13 +199,12 @@ export const MutesCmd = mutesCmd({
 
       if (totalPages > 1) {
         const idMod = `${listMessage.id}:muteList`;
-        const buttons: MessageButton[] = [];
+        const buttons = [
+          new ButtonBuilder().setStyle(ButtonStyle.Secondary).setEmoji("⬅").setCustomId(`previousButton:${idMod}`),
+          new ButtonBuilder().setStyle(ButtonStyle.Secondary).setEmoji("➡").setCustomId(`nextButton:${idMod}`),
+        ] satisfies ButtonBuilder[];
 
-        buttons.push(new MessageButton().setStyle("SECONDARY").setEmoji("⬅").setCustomId(`previousButton:${idMod}`));
-
-        buttons.push(new MessageButton().setStyle("SECONDARY").setEmoji("➡").setCustomId(`nextButton:${idMod}`));
-
-        const row = new MessageActionRow().addComponents(buttons);
+        const row = new ActionRowBuilder<ButtonBuilder>().addComponents(buttons);
         await listMessage.edit({ components: [row] });
 
         const collector = listMessage.createMessageComponentCollector({ time: stopCollectionDebounce });
@@ -207,6 +213,7 @@ export const MutesCmd = mutesCmd({
           if (msg.author.id !== interaction.user.id) {
             interaction
               .reply({ content: `You are not permitted to use these buttons.`, ephemeral: true })
+              // tslint:disable-next-line no-console
               .catch((err) => console.trace(err.message));
           } else {
             collector.resetTimer();

backend/src/plugins/Mutes/events/ReapplyActiveMuteOnJoinEvt.ts

@@ -1,9 +1,7 @@
 import { Snowflake } from "discord.js";
-import { memberToTemplateSafeMember } from "../../../utils/templateSafeObjects";
-import { LogType } from "../../../data/LogType";
 import { memberRolesLock } from "../../../utils/lockNameHelpers";
-import { mutesEvt } from "../types";
 import { LogsPlugin } from "../../Logs/LogsPlugin";
+import { mutesEvt } from "../types";
 
 /**
  * Reapply active mutes on join

backend/src/plugins/Mutes/functions/clearMute.ts

@@ -1,11 +1,11 @@
+import { GuildMember } from "discord.js";
+import { GuildPluginData } from "knub";
 import { Mute } from "../../../data/entities/Mute";
+import { clearExpiringMute } from "../../../data/loops/expiringMutesLoop";
 import { resolveMember, verboseUserMention } from "../../../utils";
 import { memberRolesLock } from "../../../utils/lockNameHelpers";
 import { LogsPlugin } from "../../Logs/LogsPlugin";
-import { GuildPluginData } from "knub";
 import { MutesPluginType } from "../types";
-import { clearExpiringMute } from "../../../data/loops/expiringMutesLoop";
-import { GuildMember } from "discord.js";
 
 export async function clearMute(
   pluginData: GuildPluginData<MutesPluginType>,

backend/src/plugins/Mutes/functions/muteUser.ts

@@ -1,9 +1,10 @@
-import { Snowflake, TextChannel, User } from "discord.js";
+import { Snowflake, User } from "discord.js";
 import humanizeDuration from "humanize-duration";
 import { GuildPluginData } from "knub";
-import { userToTemplateSafeUser } from "../../../utils/templateSafeObjects";
 import { CaseTypes } from "../../../data/CaseTypes";
 import { Case } from "../../../data/entities/Case";
+import { Mute } from "../../../data/entities/Mute";
+import { registerExpiringMute } from "../../../data/loops/expiringMutesLoop";
 import { LogsPlugin } from "../../../plugins/Logs/LogsPlugin";
 import { ERRORS, RecoverablePluginError } from "../../../RecoverablePluginError";
 import { renderTemplate, TemplateSafeValueContainer } from "../../../templateFormatter";
@@ -16,10 +17,9 @@ import {
   UserNotificationResult,
 } from "../../../utils";
 import { muteLock } from "../../../utils/lockNameHelpers";
+import { userToTemplateSafeUser } from "../../../utils/templateSafeObjects";
 import { CasesPlugin } from "../../Cases/CasesPlugin";
 import { MuteOptions, MutesPluginType } from "../types";
-import { Mute } from "../../../data/entities/Mute";
-import { registerExpiringMute } from "../../../data/loops/expiringMutesLoop";
 
 /**
  * TODO: Clean up this function
@@ -186,7 +186,7 @@ export async function muteUser(
       const channel = config.message_channel
         ? pluginData.guild.channels.cache.get(config.message_channel as Snowflake)
         : null;
-      if (useChannel && channel?.isText()) {
+      if (useChannel && channel?.isTextBased()) {
         contactMethods.push({ type: "channel", channel });
       }
     }

backend/src/plugins/Mutes/functions/unmuteUser.ts

@@ -1,17 +1,14 @@
 import { Snowflake } from "discord.js";
 import humanizeDuration from "humanize-duration";
 import { GuildPluginData } from "knub";
-import { userToTemplateSafeUser } from "../../../utils/templateSafeObjects";
 import { CaseTypes } from "../../../data/CaseTypes";
-import { LogType } from "../../../data/LogType";
 import { resolveMember, resolveUser } from "../../../utils";
-import { memberRolesLock } from "../../../utils/lockNameHelpers";
 import { CasesPlugin } from "../../Cases/CasesPlugin";
 import { CaseArgs } from "../../Cases/types";
-import { MutesPluginType, UnmuteResult } from "../types";
-import { memberHasMutedRole } from "./memberHasMutedRole";
 import { LogsPlugin } from "../../Logs/LogsPlugin";
+import { MutesPluginType, UnmuteResult } from "../types";
 import { clearMute } from "./clearMute";
+import { memberHasMutedRole } from "./memberHasMutedRole";
 
 export async function unmuteUser(
   pluginData: GuildPluginData<MutesPluginType>,

backend/src/plugins/Mutes/types.ts

@@ -1,7 +1,7 @@
 import { GuildMember } from "discord.js";
 import { EventEmitter } from "events";
 import * as t from "io-ts";
-import { BasePluginType, typedGuildCommand, typedGuildEventListener } from "knub";
+import { BasePluginType, guildPluginEventListener, guildPluginMessageCommand } from "knub";
 import { Case } from "../../data/entities/Case";
 import { Mute } from "../../data/entities/Mute";
 import { GuildArchives } from "../../data/GuildArchives";
@@ -11,8 +11,6 @@ import { GuildMutes } from "../../data/GuildMutes";
 import { tNullable, UserNotificationMethod, UserNotificationResult } from "../../utils";
 import { CaseArgs } from "../Cases/types";
 
-import Timeout = NodeJS.Timeout;
-
 export const ConfigSchema = t.type({
   mute_role: tNullable(t.string),
   move_to_voice_channel: tNullable(t.string),
@@ -79,5 +77,5 @@ export interface MuteOptions {
   isAutomodAction?: boolean;
 }
 
-export const mutesCmd = typedGuildCommand<MutesPluginType>();
-export const mutesEvt = typedGuildEventListener<MutesPluginType>();
+export const mutesCmd = guildPluginMessageCommand<MutesPluginType>();
+export const mutesEvt = guildPluginEventListener<MutesPluginType>();