Update djs & knub (#395)

* update pkgs Signed-off-by: GitHub <noreply@github.com> * new knub typings Signed-off-by: GitHub <noreply@github.com> * more pkg updates Signed-off-by: GitHub <noreply@github.com> * more fixes Signed-off-by: GitHub <noreply@github.com> * channel typings Signed-off-by: GitHub <noreply@github.com> * more message utils typings fixes Signed-off-by: GitHub <noreply@github.com> * migrate permissions Signed-off-by: GitHub <noreply@github.com> * fix: InternalPoster webhookables Signed-off-by: GitHub <noreply@github.com> * djs typings: Attachment & Util Signed-off-by: GitHub <noreply@github.com> * more typings Signed-off-by: GitHub <noreply@github.com> * fix: rename permissionNames Signed-off-by: GitHub <noreply@github.com> * more fixes Signed-off-by: GitHub <noreply@github.com> * half the number of errors * knub commands => messageCommands Signed-off-by: GitHub <noreply@github.com> * configPreprocessor => configParser Signed-off-by: GitHub <noreply@github.com> * fix channel.messages Signed-off-by: GitHub <noreply@github.com> * revert automod any typing Signed-off-by: GitHub <noreply@github.com> * more configParser typings Signed-off-by: GitHub <noreply@github.com> * revert Signed-off-by: GitHub <noreply@github.com> * remove knub type params Signed-off-by: GitHub <noreply@github.com> * fix more MessageEmbed / MessageOptions Signed-off-by: GitHub <noreply@github.com> * dumb commit for @almeidx to see why this is stupid Signed-off-by: GitHub <noreply@github.com> * temp disable custom_events Signed-off-by: GitHub <noreply@github.com> * more minor typings fixes - 23 err left Signed-off-by: GitHub <noreply@github.com> * update djs dep * +debug build method (revert this) Signed-off-by: GitHub <noreply@github.com> * Revert "+debug build method (revert this)" This reverts commit a80af1e729. * Redo +debug build (Revert this) Signed-off-by: GitHub <noreply@github.com> * uniform before/after Load shorthands Signed-off-by: GitHub <noreply@github.com> * remove unused imports & add prettier plugin Signed-off-by: GitHub <noreply@github.com> * env fixes for web platform hosting Signed-off-by: GitHub <noreply@github.com> * feat: knub v32-next; related fixes * fix: allow legacy keys in change_perms action * fix: request Message Content intent * fix: use Knub's config validation logic in API * fix(dashboard): fix error when there are no message and/or slash commands in a plugin * fix(automod): start_thread action thread options * fix(CustomEvents): message command types * chore: remove unneeded type annotation * feat: add forum channel icon; use thread icon for news threads * chore: make tslint happy * chore: fix formatting --------- Signed-off-by: GitHub <noreply@github.com> Co-authored-by: almeidx <almeidx@pm.me> Co-authored-by: Dragory <2606411+Dragory@users.noreply.github.com>
2025-05-17 07:05:03 +00:00 · 2023-04-01 12:58:17 +01:00 · 2023-04-01 12:58:17 +01:00 · 06877e90cc
commit 06877e90cc
parent 293115af22
476 changed files with 2965 additions and 3251 deletions
--- a/backend/src/plugins/ReactionRoles/ReactionRolesPlugin.ts
+++ b/backend/src/plugins/ReactionRoles/ReactionRolesPlugin.ts
@ -1,6 +1,7 @@
 import { PluginOptions } from "knub";
 import { GuildReactionRoles } from "../../data/GuildReactionRoles";
 import { GuildSavedMessages } from "../../data/GuildSavedMessages";
+import { makeIoTsConfigParser } from "../../pluginUtils";
 import { Queue } from "../../Queue";
 import { LogsPlugin } from "../Logs/LogsPlugin";
 import { zeppelinGuildPlugin } from "../ZeppelinPluginBlueprint";
@ -39,14 +40,15 @@ export const ReactionRolesPlugin = zeppelinGuildPlugin<ReactionRolesPluginType>(
  info: {
    prettyName: "Reaction roles",
    legacy: "Consider using the [Role buttons](/docs/plugins/role_buttons) plugin instead.",
+    configSchema: ConfigSchema,
  },

  dependencies: () => [LogsPlugin],
-  configSchema: ConfigSchema,
+  configParser: makeIoTsConfigParser(ConfigSchema),
  defaultOptions,

  // prettier-ignore
-  commands: [
+  messageCommands: [
    RefreshReactionRolesCmd,
    ClearReactionRolesCmd,
    InitReactionRolesCmd,
@ -79,8 +81,10 @@ export const ReactionRolesPlugin = zeppelinGuildPlugin<ReactionRolesPluginType>(
  },

  beforeUnload(pluginData) {
-    if (pluginData.state.autoRefreshTimeout) {
-      clearTimeout(pluginData.state.autoRefreshTimeout);
+    const { state, guild } = pluginData;
+
+    if (state.autoRefreshTimeout) {
+      clearTimeout(state.autoRefreshTimeout);
    }
  },
 });
--- a/backend/src/plugins/ReactionRoles/types.ts
+++ b/backend/src/plugins/ReactionRoles/types.ts
@ -1,5 +1,5 @@
 import * as t from "io-ts";
-import { BasePluginType, typedGuildCommand, typedGuildEventListener } from "knub";
+import { BasePluginType, guildPluginEventListener, guildPluginMessageCommand } from "knub";
 import { GuildReactionRoles } from "../../data/GuildReactionRoles";
 import { GuildSavedMessages } from "../../data/GuildSavedMessages";
 import { Queue } from "../../Queue";
@ -43,5 +43,5 @@ export interface ReactionRolesPluginType extends BasePluginType {
  };
 }

-export const reactionRolesCmd = typedGuildCommand<ReactionRolesPluginType>();
-export const reactionRolesEvt = typedGuildEventListener<ReactionRolesPluginType>();
+export const reactionRolesCmd = guildPluginMessageCommand<ReactionRolesPluginType>();
+export const reactionRolesEvt = guildPluginEventListener<ReactionRolesPluginType>();
--- a/backend/src/plugins/ReactionRoles/util/addMemberPendingRoleChange.ts
+++ b/backend/src/plugins/ReactionRoles/util/addMemberPendingRoleChange.ts
@ -31,12 +31,7 @@ export async function addMemberPendingRoleChange(
          }

          try {
-            await member.edit(
-              {
-                roles: Array.from(newRoleIds.values()),
-              },
-              "Reaction roles",
-            );
+            await member.roles.set(Array.from(newRoleIds.values()), "Reaction roles");
          } catch (e) {
            logger.warn(`Failed to apply role changes to ${member.user.tag} (${member.id}): ${e.message}`);
          }
--- a/backend/src/plugins/ReactionRoles/util/applyReactionRoleReactionsToMessage.ts
+++ b/backend/src/plugins/ReactionRoles/util/applyReactionRoleReactionsToMessage.ts
@ -1,4 +1,4 @@
-import { Snowflake, TextChannel } from "discord.js";
+import { Snowflake } from "discord.js";
 import { GuildPluginData } from "knub";
 import { ReactionRole } from "../../../data/entities/ReactionRole";
 import { isDiscordAPIError, sleep } from "../../../utils";
@ -16,15 +16,15 @@ export async function applyReactionRoleReactionsToMessage(
  messageId: string,
  reactionRoles: ReactionRole[],
 ): Promise<string[] | undefined> {
-  const channel = pluginData.guild.channels.cache.get(channelId as Snowflake) as TextChannel;
-  if (!channel) return;
+  const channel = pluginData.guild.channels.cache.get(channelId as Snowflake);
+  if (!channel?.isTextBased()) return;

  const errors: string[] = [];
  const logs = pluginData.getPlugin(LogsPlugin);

  let targetMessage;
  try {
-    targetMessage = await channel.messages.fetch(messageId, { force: true });
+    targetMessage = await channel.messages.fetch({ message: messageId, force: true });
  } catch (e) {
    if (isDiscordAPIError(e)) {
      if (e.code === 10008) {