StyAndCo/zeppelin
3
0
Fork 0
mirror of https://github.com/ZeppelinBot/Zeppelin.git synced 2025-05-19 08:05:01 +00:00
Code Releases Activity

Add mass role add/remove commands. Fix UnknownUser mentions in logs. Fix unnecessary audit log reads when adding/removing roles and the log type is ignored.

Browse source
This commit is contained in:
Dragory 2020-03-28 15:21:13 +02:00
parent 6384b31aa7
commit 1f2e8f6e6d
5 changed files with 220 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

134
backend/src/plugins/Roles.ts
View file

@ -1,13 +1,14 @@
import { ZeppelinPlugin, trimPluginDescription } from "./ZeppelinPlugin";
import { trimPluginDescription, ZeppelinPlugin } from "./ZeppelinPlugin";
import * as t from "io-ts";
import { stripObjectToScalars, tNullable } from "../utils";
import { decorators as d, IPluginOptions, logger, waitForReaction, waitForReply } from "knub";
import { Attachment, Constants as ErisConstants, Guild, GuildChannel, Member, Message, TextChannel, User } from "eris";
import { stripObjectToScalars, successMessage } from "../utils";
import { decorators as d, IPluginOptions, logger } from "knub";
import { GuildChannel, Member, Message } from "eris";
import { GuildLogs } from "../data/GuildLogs";
import { LogType } from "../data/LogType";
const ConfigSchema = t.type({
can_assign: t.boolean,
can_mass_assign: t.boolean,
assignable_roles: t.array(t.string),
});
type TConfigSchema = t.TypeOf<typeof ConfigSchema>;
@ -33,6 +34,7 @@ export class RolesPlugin extends ZeppelinPlugin<TConfigSchema> {
return {
config: {
can_assign: false,
can_mass_assign: false,
assignable_roles: [],
},
overrides: [
@ -42,11 +44,17 @@ export class RolesPlugin extends ZeppelinPlugin<TConfigSchema> {
can_assign: true,
},
},
{
level: ">=100",
config: {
can_mass_assign: true,
},
},
],
};
}
@d.command("addrole", "<member:member> [role:string$]", {
@d.command("addrole", "<member:member> <role:string$>", {
extra: {
info: {
description: "Add a role to the specified member",
@ -95,7 +103,64 @@ export class RolesPlugin extends ZeppelinPlugin<TConfigSchema> {
this.sendSuccessMessage(msg.channel, "Role added to user!");
}
@d.command("removerole", "<member:member> [role:string$]", {
@d.command("massaddrole", "<role:string> <members:member...>")
@d.permission("can_mass_assign")
async massAddRoleCmd(msg: Message, args: { role: string; members: Member[] }) {
for (const member of args.members) {
if (!this.canActOn(msg.member, member, true)) {
return this.sendErrorMessage(
msg.channel,
"Cannot add roles to 1 or more specified members: insufficient permissions",
);
}
}
const roleId = await this.resolveRoleId(args.role);
if (!roleId) {
return this.sendErrorMessage(msg.channel, "Invalid role id");
}
const role = this.guild.roles.get(roleId);
const config = this.getConfigForMsg(msg);
if (!config.assignable_roles.includes(roleId)) {
return this.sendErrorMessage(msg.channel, "You cannot assign that role");
}
const membersWithoutTheRole = args.members.filter(m => !m.roles.includes(roleId));
let assigned = 0;
let failed = 0;
const alreadyHadRole = args.members.length - membersWithoutTheRole.length;
msg.channel.createMessage(`Adding role to specified members...`);
for (const member of membersWithoutTheRole) {
try {
this.logs.ignoreLog(LogType.MEMBER_ROLE_ADD, member.id);
await member.addRole(roleId);
this.logs.log(LogType.MEMBER_ROLE_ADD, {
member: stripObjectToScalars(member, ["user", "roles"]),
roles: role.name,
mod: stripObjectToScalars(msg.author),
});
assigned++;
} catch (e) {
logger.warn(`Error when adding role via !massaddrole: ${e.message}`);
failed++;
}
}
let resultMessage = `Role added to ${assigned} ${assigned === 1 ? "member" : "members"}!`;
if (failed > 0) {
resultMessage += ` Failed to add the role to ${failed} ${failed === 1 ? "member" : "members"}.`;
}
if (alreadyHadRole) {
resultMessage += ` ${alreadyHadRole} ${alreadyHadRole === 1 ? "member" : "members"} already had the role.`;
}
msg.channel.createMessage(successMessage(resultMessage));
}
@d.command("removerole", "<member:member> <role:string$>", {
extra: {
info: {
description: "Remove a role from the specified member",
@ -143,4 +208,61 @@ export class RolesPlugin extends ZeppelinPlugin<TConfigSchema> {
this.sendSuccessMessage(msg.channel, "Role removed from user!");
}
@d.command("massremoverole", "<role:string> <members:member...>")
@d.permission("can_mass_assign")
async massRemoveRoleCmd(msg: Message, args: { role: string; members: Member[] }) {
for (const member of args.members) {
if (!this.canActOn(msg.member, member, true)) {
return this.sendErrorMessage(
msg.channel,
"Cannot add roles to 1 or more specified members: insufficient permissions",
);
}
}
const roleId = await this.resolveRoleId(args.role);
if (!roleId) {
return this.sendErrorMessage(msg.channel, "Invalid role id");
}
const role = this.guild.roles.get(roleId);
const config = this.getConfigForMsg(msg);
if (!config.assignable_roles.includes(roleId)) {
return this.sendErrorMessage(msg.channel, "You cannot remove that role");
}
const membersWithTheRole = args.members.filter(m => m.roles.includes(roleId));
let assigned = 0;
let failed = 0;
const didNotHaveRole = args.members.length - membersWithTheRole.length;
msg.channel.createMessage(`Removing role from specified members...`);
for (const member of membersWithTheRole) {
try {
this.logs.ignoreLog(LogType.MEMBER_ROLE_REMOVE, member.id);
await member.removeRole(roleId);
this.logs.log(LogType.MEMBER_ROLE_REMOVE, {
member: stripObjectToScalars(member, ["user", "roles"]),
roles: role.name,
mod: stripObjectToScalars(msg.author),
});
assigned++;
} catch (e) {
logger.warn(`Error when removing role via !massremoverole: ${e.message}`);
failed++;
}
}
let resultMessage = `Role removed from ${assigned} ${assigned === 1 ? "member" : "members"}!`;
if (failed > 0) {
resultMessage += ` Failed to remove the role from ${failed} ${failed === 1 ? "member" : "members"}.`;
}
if (didNotHaveRole) {
resultMessage += ` ${didNotHaveRole} ${didNotHaveRole === 1 ? "member" : "members"} didn't have the role.`;
}
msg.channel.createMessage(successMessage(resultMessage));
}
}