From 37024ff1e45ab17a66322677654603e3d90d61da Mon Sep 17 00:00:00 2001
From: Almeida <almeidx@pm.me>
Date: Wed, 5 May 2021 19:32:18 +0100
Subject: [PATCH] made length check more readable

---
 backend/src/plugins/Utility/commands/NicknameCmd.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/backend/src/plugins/Utility/commands/NicknameCmd.ts b/backend/src/plugins/Utility/commands/NicknameCmd.ts
index a5a637e3..39374fbc 100644
--- a/backend/src/plugins/Utility/commands/NicknameCmd.ts
+++ b/backend/src/plugins/Utility/commands/NicknameCmd.ts
@@ -25,10 +25,12 @@ export const NicknameCmd = utilityCmd({
       return;
     }
 
-    const nicknameLength = args.nickname && [...args.nickname].length;
-    if (typeof nicknameLength === "number" && (nicknameLength < 2 || nicknameLength > 32)) {
-      msg.channel.send(errorMessage("Nickname must be between 2 and 32 characters long"));
-      return;
+    if (args.nickname) {
+      const nicknameLength = [...args.nickname].length;
+      if (nicknameLength < 2 || nicknameLength > 32) {
+        msg.channel.send(errorMessage("Nickname must be between 2 and 32 characters long"));
+        return;
+      }
     }
 
     const oldNickname = args.member.nickname || "<none>";