Turn on strict TS compilation. Fix up and tweak types accordingly.

backend/src/plugins/ModActions/commands/AddCaseCmd.ts

@@ -65,7 +65,7 @@ export const AddCaseCmd = modActionsCmd({
       modId: mod.id,
       type: CaseTypes[type],
       reason,
-      ppId: mod.id !== msg.author.id ? msg.author.id : null,
+      ppId: mod.id !== msg.author.id ? msg.author.id : undefined,
     });
 
     if (user) {

backend/src/plugins/ModActions/commands/BanCmd.ts

@@ -78,7 +78,7 @@ export const BanCmd = modActionsCmd({
       contactMethods,
       caseArgs: {
         modId: mod.id,
-        ppId: mod.id !== msg.author.id ? msg.author.id : null,
+        ppId: mod.id !== msg.author.id ? msg.author.id : undefined,
       },
       deleteMessageDays,
     });

backend/src/plugins/ModActions/commands/DeleteCaseCmd.ts

@@ -9,6 +9,7 @@ import { LogsPlugin } from "../../Logs/LogsPlugin";
 import { LogType } from "../../../data/LogType";
 import moment from "moment-timezone";
 import { TimeAndDatePlugin } from "../../TimeAndDate/TimeAndDatePlugin";
+import { Case } from "../../../data/entities/Case";
 
 export const DeleteCaseCmd = modActionsCmd({
   trigger: ["delete_case", "deletecase"],
@@ -25,8 +26,8 @@ export const DeleteCaseCmd = modActionsCmd({
   },
 
   async run({ pluginData, message, args }) {
-    const failed = [];
-    const validCases = [];
+    const failed: number[] = [];
+    const validCases: Case[] = [];
     let cancelled = 0;
 
     for (const num of args.caseNumber) {

backend/src/plugins/ModActions/commands/ForcebanCmd.ts

@@ -77,7 +77,7 @@ export const ForcebanCmd = modActionsCmd({
       modId: mod.id,
       type: CaseTypes.Ban,
       reason,
-      ppId: mod.id !== msg.author.id ? msg.author.id : null,
+      ppId: mod.id !== msg.author.id ? msg.author.id : undefined,
     });
 
     // Confirm the action

backend/src/plugins/ModActions/commands/HideCaseCmd.ts

@@ -14,7 +14,7 @@ export const HideCaseCmd = modActionsCmd({
   ],
 
   async run({ pluginData, message: msg, args }) {
-    const failed = [];
+    const failed: number[] = [];
 
     for (const num of args.caseNum) {
       const theCase = await pluginData.state.cases.findByCaseNumber(num);

backend/src/plugins/ModActions/commands/MassBanCmd.ts

@@ -62,7 +62,7 @@ export const MassbanCmd = modActionsCmd({
     const loadingMsg = await msg.channel.createMessage("Banning...");
 
     // Ban each user and count failed bans (if any)
-    const failedBans = [];
+    const failedBans: string[] = [];
     const casesPlugin = pluginData.getPlugin(CasesPlugin);
     for (const userId of args.userIds) {
       try {

backend/src/plugins/ModActions/commands/MassmuteCmd.ts

@@ -62,7 +62,7 @@ export const MassmuteCmd = modActionsCmd({
 
     // Mute everyone and count fails
     const modId = msg.author.id;
-    const failedMutes = [];
+    const failedMutes: string[] = [];
     const mutesPlugin = pluginData.getPlugin(MutesPlugin);
     for (const userId of args.userIds) {
       try {

backend/src/plugins/ModActions/commands/UnbanCmd.ts

@@ -59,7 +59,7 @@ export const UnbanCmd = modActionsCmd({
       modId: mod.id,
       type: CaseTypes.Unban,
       reason,
-      ppId: mod.id !== msg.author.id ? msg.author.id : null,
+      ppId: mod.id !== msg.author.id ? msg.author.id : undefined,
     });
 
     // Confirm the action

backend/src/plugins/ModActions/commands/UnhideCaseCmd.ts

@@ -14,7 +14,7 @@ export const UnhideCaseCmd = modActionsCmd({
   ],
 
   async run({ pluginData, message: msg, args }) {
-    const failed = [];
+    const failed: number[] = [];
 
     for (const num of args.caseNum) {
       const theCase = await pluginData.state.cases.findByCaseNumber(num);

backend/src/plugins/ModActions/commands/UpdateCmd.ts

@@ -24,7 +24,7 @@ export const UpdateCmd = modActionsCmd({
   ],
 
   async run({ pluginData, message: msg, args }) {
-    let theCase: Case;
+    let theCase: Case | undefined;
     if (args.caseNumber != null) {
       theCase = await pluginData.state.cases.findByCaseNumber(args.caseNumber);
     } else {

backend/src/plugins/ModActions/commands/WarnCmd.ts

@@ -91,7 +91,7 @@ export const WarnCmd = modActionsCmd({
       contactMethods,
       caseArgs: {
         modId: mod.id,
-        ppId: mod.id !== msg.author.id ? msg.author.id : null,
+        ppId: mod.id !== msg.author.id ? msg.author.id : undefined,
         reason,
       },
       retryPromptChannel: msg.channel as TextChannel,