From 673ec7b09a2725952cb8e6de0006ab4398a7c6c9 Mon Sep 17 00:00:00 2001
From: Dragory <2606411+Dragory@users.noreply.github.com>
Date: Wed, 3 Nov 2021 16:59:08 +0200
Subject: [PATCH] chore: resolve eslint issues

---
 backend/src/data/GuildCases.ts                              | 2 ++
 backend/src/data/loops/expiredArchiveDeletionLoop.ts        | 2 ++
 backend/src/data/loops/expiringMutesLoop.ts                 | 2 ++
 backend/src/data/loops/expiringTempbansLoop.ts              | 2 ++
 backend/src/data/loops/expiringVCAlertsLoop.ts              | 2 ++
 backend/src/data/loops/phishermanLoops.ts                   | 2 ++
 backend/src/data/loops/savedMessageCleanupLoop.ts           | 2 ++
 backend/src/data/loops/upcomingRemindersLoop.ts             | 2 ++
 backend/src/data/loops/upcomingScheduledPostsLoop.ts        | 2 ++
 backend/src/index.ts                                        | 6 ++++++
 backend/src/logger.ts                                       | 2 +-
 backend/src/plugins/Automod/actions/clean.ts                | 2 ++
 .../plugins/GuildAccessMonitor/GuildAccessMonitorPlugin.ts  | 1 +
 .../GuildConfigReloader/functions/reloadChangedGuilds.ts    | 1 +
 .../functions/getOrCreateWebhookForChannel.ts               | 1 +
 .../src/plugins/ModActions/functions/actualMuteUserCmd.ts   | 3 ++-
 backend/src/plugins/Reminders/functions/postReminder.ts     | 1 +
 backend/src/validatorUtils.ts                               | 1 +
 backend/src/yamlParseTest.ts                                | 1 +
 19 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/backend/src/data/GuildCases.ts b/backend/src/data/GuildCases.ts
index 3010ee36..9c41c8b6 100644
--- a/backend/src/data/GuildCases.ts
+++ b/backend/src/data/GuildCases.ts
@@ -159,6 +159,8 @@ export class GuildCases extends BaseGuildRepository {
         .catch((err) => {
           if (err?.code === "ER_DUP_ENTRY") {
             if (data.audit_log_id) {
+              // FIXME: Debug
+              // tslint:disable-next-line:no-console
               console.trace(`Tried to insert case with duplicate audit_log_id`);
               return this.createInternal({
                 ...data,
diff --git a/backend/src/data/loops/expiredArchiveDeletionLoop.ts b/backend/src/data/loops/expiredArchiveDeletionLoop.ts
index c3f3c61b..7aa794ed 100644
--- a/backend/src/data/loops/expiredArchiveDeletionLoop.ts
+++ b/backend/src/data/loops/expiredArchiveDeletionLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, MINUTES } from "../../utils";
 import { Archives } from "../Archives";
 import moment from "moment-timezone";
diff --git a/backend/src/data/loops/expiringMutesLoop.ts b/backend/src/data/loops/expiringMutesLoop.ts
index ba62ad19..027a3ac9 100644
--- a/backend/src/data/loops/expiringMutesLoop.ts
+++ b/backend/src/data/loops/expiringMutesLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, memoize, MINUTES } from "../../utils";
 import { Mutes } from "../Mutes";
 import Timeout = NodeJS.Timeout;
diff --git a/backend/src/data/loops/expiringTempbansLoop.ts b/backend/src/data/loops/expiringTempbansLoop.ts
index 67d32d8e..cef9b547 100644
--- a/backend/src/data/loops/expiringTempbansLoop.ts
+++ b/backend/src/data/loops/expiringTempbansLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, MINUTES } from "../../utils";
 import moment from "moment-timezone";
 import { emitGuildEvent, hasGuildEventListener } from "../GuildEvents";
diff --git a/backend/src/data/loops/expiringVCAlertsLoop.ts b/backend/src/data/loops/expiringVCAlertsLoop.ts
index 20036ecf..54bb7032 100644
--- a/backend/src/data/loops/expiringVCAlertsLoop.ts
+++ b/backend/src/data/loops/expiringVCAlertsLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, MINUTES } from "../../utils";
 import moment from "moment-timezone";
 import { emitGuildEvent, hasGuildEventListener } from "../GuildEvents";
diff --git a/backend/src/data/loops/phishermanLoops.ts b/backend/src/data/loops/phishermanLoops.ts
index 507f2166..1ed9a2d2 100644
--- a/backend/src/data/loops/phishermanLoops.ts
+++ b/backend/src/data/loops/phishermanLoops.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { HOURS, MINUTES } from "../../utils";
 import {
   deleteStalePhishermanCacheEntries,
diff --git a/backend/src/data/loops/savedMessageCleanupLoop.ts b/backend/src/data/loops/savedMessageCleanupLoop.ts
index b62e520c..b5b4dcc7 100644
--- a/backend/src/data/loops/savedMessageCleanupLoop.ts
+++ b/backend/src/data/loops/savedMessageCleanupLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { MINUTES } from "../../utils";
 import { cleanupMessages } from "../cleanup/messages";
 
diff --git a/backend/src/data/loops/upcomingRemindersLoop.ts b/backend/src/data/loops/upcomingRemindersLoop.ts
index 6c1449a4..b3aa2f4b 100644
--- a/backend/src/data/loops/upcomingRemindersLoop.ts
+++ b/backend/src/data/loops/upcomingRemindersLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, MINUTES } from "../../utils";
 import moment from "moment-timezone";
 import { emitGuildEvent, hasGuildEventListener } from "../GuildEvents";
diff --git a/backend/src/data/loops/upcomingScheduledPostsLoop.ts b/backend/src/data/loops/upcomingScheduledPostsLoop.ts
index 57ae896b..465939f4 100644
--- a/backend/src/data/loops/upcomingScheduledPostsLoop.ts
+++ b/backend/src/data/loops/upcomingScheduledPostsLoop.ts
@@ -1,3 +1,5 @@
+// tslint:disable:no-console
+
 import { lazyMemoize, MINUTES } from "../../utils";
 import moment from "moment-timezone";
 import { emitGuildEvent, hasGuildEventListener } from "../GuildEvents";
diff --git a/backend/src/index.ts b/backend/src/index.ts
index 2f52ba8f..deceb3be 100644
--- a/backend/src/index.ts
+++ b/backend/src/index.ts
@@ -184,6 +184,8 @@ setInterval(() => {
 }, 500);
 setInterval(() => {
   const avgBlocking = avgTotal / (avgCount || 1);
+  // FIXME: Debug
+  // tslint:disable-next-line:no-console
   console.log(`Average blocking in the last 5min: ${avgBlocking / avgTotal}ms`);
   avgTotal = 0;
   avgCount = 0;
@@ -387,6 +389,8 @@ connect().then(async () => {
     lowestGlobalRemaining = Math.min(lowestGlobalRemaining, (client as any).rest.globalRemaining);
   }, 100);
   setInterval(() => {
+    // FIXME: Debug
+    // tslint:disable-next-line:no-console
     console.log("Lowest global remaining in the past 15 seconds:", lowestGlobalRemaining);
     lowestGlobalRemaining = Infinity;
   }, 15000);
@@ -399,6 +403,8 @@ connect().then(async () => {
       .slice(0, 5)
       .map(([key, count]) => `${count}x ${key}`)
       .join("\n");
+    // FIXME: Debug
+    // tslint:disable-next-line:no-console
     console.log(`Top query entries in the past 5 minutes:\n${topEntriesStr}`);
   }, 5 * MINUTES);
 
diff --git a/backend/src/logger.ts b/backend/src/logger.ts
index 6b3f1b96..cbb48b40 100644
--- a/backend/src/logger.ts
+++ b/backend/src/logger.ts
@@ -1,4 +1,4 @@
-// tslint-disable:no-console
+// tslint:disable:no-console
 
 export const logger = {
   info(...args: Parameters<typeof console.log>) {
diff --git a/backend/src/plugins/Automod/actions/clean.ts b/backend/src/plugins/Automod/actions/clean.ts
index 56d5be64..27ee1cb6 100644
--- a/backend/src/plugins/Automod/actions/clean.ts
+++ b/backend/src/plugins/Automod/actions/clean.ts
@@ -17,6 +17,8 @@ export const CleanAction = automodAction({
         }
 
         if (messageIdsToDeleteByChannelId.get(context.message.channel_id)!.includes(context.message.id)) {
+          // FIXME: Debug
+          // tslint:disable-next-line:no-console
           console.warn(`Message ID to delete was already present: ${pluginData.guild.name}, rule ${ruleName}`);
           continue;
         }
diff --git a/backend/src/plugins/GuildAccessMonitor/GuildAccessMonitorPlugin.ts b/backend/src/plugins/GuildAccessMonitor/GuildAccessMonitorPlugin.ts
index 34952bbd..d181ad7a 100644
--- a/backend/src/plugins/GuildAccessMonitor/GuildAccessMonitorPlugin.ts
+++ b/backend/src/plugins/GuildAccessMonitor/GuildAccessMonitorPlugin.ts
@@ -13,6 +13,7 @@ interface GuildAccessMonitorPluginType extends BasePluginType {
 
 async function checkGuild(pluginData: GlobalPluginData<GuildAccessMonitorPluginType>, guild: Guild) {
   if (!(await pluginData.state.allowedGuilds.isAllowed(guild.id))) {
+    // tslint:disable-next-line:no-console
     console.log(`Non-allowed server ${guild.name} (${guild.id}), leaving`);
     guild.leave();
   }
diff --git a/backend/src/plugins/GuildConfigReloader/functions/reloadChangedGuilds.ts b/backend/src/plugins/GuildConfigReloader/functions/reloadChangedGuilds.ts
index bc7eb6e9..f18d3c45 100644
--- a/backend/src/plugins/GuildConfigReloader/functions/reloadChangedGuilds.ts
+++ b/backend/src/plugins/GuildConfigReloader/functions/reloadChangedGuilds.ts
@@ -13,6 +13,7 @@ export async function reloadChangedGuilds(pluginData: GlobalPluginData<GuildConf
     if (!item.key.startsWith("guild-")) continue;
 
     const guildId = item.key.slice("guild-".length) as Snowflake;
+    // tslint:disable-next-line:no-console
     console.log(`Config changed, reloading guild ${guildId}`);
     await pluginData.getKnubInstance().reloadGuild(guildId);
 
diff --git a/backend/src/plugins/InternalPoster/functions/getOrCreateWebhookForChannel.ts b/backend/src/plugins/InternalPoster/functions/getOrCreateWebhookForChannel.ts
index 9d2fb029..8acd2887 100644
--- a/backend/src/plugins/InternalPoster/functions/getOrCreateWebhookForChannel.ts
+++ b/backend/src/plugins/InternalPoster/functions/getOrCreateWebhookForChannel.ts
@@ -35,6 +35,7 @@ export async function getOrCreateWebhookForChannel(
       });
       return [webhook.id, webhook.token!];
     } catch (err) {
+      // tslint:disable-next-line:no-console
       console.warn(`Error when trying to create webhook for ${pluginData.guild.id}/${channel.id}: ${err.message}`);
 
       if (isDiscordAPIError(err) && err.code === 50013) {
diff --git a/backend/src/plugins/ModActions/functions/actualMuteUserCmd.ts b/backend/src/plugins/ModActions/functions/actualMuteUserCmd.ts
index f790604a..6a750fd5 100644
--- a/backend/src/plugins/ModActions/functions/actualMuteUserCmd.ts
+++ b/backend/src/plugins/ModActions/functions/actualMuteUserCmd.ts
@@ -71,7 +71,8 @@ export async function actualMuteUserCmd(
     } else {
       logger.error(`Failed to mute user ${user.id}: ${e.stack}`);
       if (user.id == null) {
-        // tslint-disable-next-line:no-console
+        // FIXME: Debug
+        // tslint:disable-next-line:no-console
         console.trace("[DEBUG] Null user.id for mute");
       }
       sendErrorMessage(pluginData, msg.channel as TextChannel, "Could not mute the user");
diff --git a/backend/src/plugins/Reminders/functions/postReminder.ts b/backend/src/plugins/Reminders/functions/postReminder.ts
index 85b95cb8..665fc3fb 100644
--- a/backend/src/plugins/Reminders/functions/postReminder.ts
+++ b/backend/src/plugins/Reminders/functions/postReminder.ts
@@ -32,6 +32,7 @@ export async function postReminder(pluginData: GuildPluginData<RemindersPluginTy
       }
     } catch (err) {
       // If we were unable to post the reminder, we'll try again later
+      // tslint:disable-next-line:no-console
       console.warn(`Error when posting reminder for ${reminder.user_id} in guild ${reminder.guild_id}: ${String(err)}`);
       return;
     }
diff --git a/backend/src/validatorUtils.ts b/backend/src/validatorUtils.ts
index 7b75637c..24a9c080 100644
--- a/backend/src/validatorUtils.ts
+++ b/backend/src/validatorUtils.ts
@@ -123,6 +123,7 @@ export function decodeAndValidateStrict<T extends t.HasProps>(
       (result) => {
         // Make sure there are no extra properties
         if (debug) {
+          // tslint:disable-next-line:no-console
           console.log(
             "JSON.stringify() check:",
             JSON.stringify(value) === JSON.stringify(result)
diff --git a/backend/src/yamlParseTest.ts b/backend/src/yamlParseTest.ts
index 2838591c..5db961ff 100644
--- a/backend/src/yamlParseTest.ts
+++ b/backend/src/yamlParseTest.ts
@@ -19,4 +19,5 @@ const yaml = new YAML(src);
 json.plugins.myplugin.config.can_do_thing = false;
 yaml.json = json;
 
+// tslint:disable-next-line:no-console
 console.log(yaml.yaml);