StyAndCo/zeppelin
3
0
Fork 0
mirror of https://github.com/ZeppelinBot/Zeppelin.git synced 2025-03-14 21:31:50 +00:00
Code Releases Activity

cases: fix cases without a reason not being posted

Browse source 
The fact that cases *with* a reason were being posted was actually an
unintended side effect of createCaseNote also posting the case after
creating the note. Had the issue with the cases not being posted not
existed, new cases with a reason would've been posted twice. This commit
changes this so createCaseNote doesn't post the case when used from
createCase, and fixes the actual case posting at the end of createCase.
This commit is contained in:
Dragory 2019-01-03 04:30:16 +02:00
parent ae158d6b48
commit ca44746ae6
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/plugins/Cases.ts
View file

@ -52,8 +52,8 @@ export class CasesPlugin extends ZeppelinPlugin {
this.actions.unregister("postCase");
}
protected async resolveCase(caseOrCaseId: Case | number): Promise<Case> {
return caseOrCaseId instanceof Case ? caseOrCaseId : this.cases.with("notes").find(caseOrCaseId);
protected resolveCaseId(caseOrCaseId: Case | number): number {
return caseOrCaseId instanceof Case ? caseOrCaseId.id : caseOrCaseId;
}
/**
@ -85,7 +85,7 @@ export class CasesPlugin extends ZeppelinPlugin {
});
if (reason) {
await this.createCaseNote(createdCase, modId, reason);
await this.createCaseNote(createdCase, modId, reason, automatic, false);
}
if (
@ -114,7 +114,7 @@ export class CasesPlugin extends ZeppelinPlugin {
const mod = this.bot.users.get(modId);
const modName = mod ? `${mod.username}#${mod.discriminator}` : "Unknown#0000";
const theCase = await this.resolveCase(caseOrCaseId);
const theCase = await this.cases.find(this.resolveCaseId(caseOrCaseId));
if (!theCase) {
this.throwPluginRuntimeError(`Unknown case ID: ${caseOrCaseId}`);
}
@ -144,7 +144,7 @@ export class CasesPlugin extends ZeppelinPlugin {
* Returns a Discord embed for the specified case
*/
public async getCaseEmbed(caseOrCaseId: Case | number): Promise<MessageContent> {
const theCase = await this.resolveCase(caseOrCaseId);
const theCase = await this.cases.with("notes").find(this.resolveCaseId(caseOrCaseId));
if (!theCase) return null;
const createdAt = moment(theCase.created_at);